From 6a9bfb503f6b41a1d491fe2ae10605de840a0574 Mon Sep 17 00:00:00 2001 From: Mikhail Klementev Date: Sun, 25 Feb 2024 18:02:39 +0000 Subject: [PATCH] refactor: set qemu default values as constants --- qemu/qemu-kernel.go | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/qemu/qemu-kernel.go b/qemu/qemu-kernel.go index 335a1e3..e24d8b0 100644 --- a/qemu/qemu-kernel.go +++ b/qemu/qemu-kernel.go @@ -37,6 +37,13 @@ const ( unsupported = "unsupported" // for test purposes ) +const ( + DefaultCPUs = 1 + DefaultMemory = 512 // megabytes + DefaultSSHRetries = 4 + DefaultSSHRetryTimeout = time.Second / 4 +) + // Kernel describe kernel parameters for qemu type Kernel struct { Name string @@ -123,11 +130,10 @@ func NewSystem(arch arch, kernel Kernel, drivePath string) (q *System, err error } q.drivePath = drivePath - // Default values - q.Cpus = 1 - q.Memory = 512 // megabytes - q.SSH.Retries = 4 - q.SSH.RetryTimeout = time.Second / 4 + q.Cpus = DefaultCPUs + q.Memory = DefaultMemory + q.SSH.Retries = DefaultSSHRetries + q.SSH.RetryTimeout = DefaultSSHRetryTimeout return }