From 603621117270e77b6cbe14ba8ac4e72846aa97cb Mon Sep 17 00:00:00 2001 From: Mikhail Klementev Date: Tue, 20 Feb 2024 11:37:19 +0000 Subject: [PATCH] refactor: errors --- cache/cache.go | 6 +++--- cmd/db.go | 2 +- cmd/debug.go | 2 +- cmd/images.go | 2 +- cmd/kernel.go | 4 ++-- cmd/pew.go | 4 ++-- 6 files changed, 10 insertions(+), 10 deletions(-) diff --git a/cache/cache.go b/cache/cache.go index 0f06214..f6f6c69 100644 --- a/cache/cache.go +++ b/cache/cache.go @@ -55,10 +55,10 @@ func DownloadRootFS(path, file string) (err error) { resp, err := grab.Get(tmp, fileurl) if err != nil { - err = fmt.Errorf("Cannot download %s. It looks like you need "+ + err = fmt.Errorf("cannot download %s. It looks like you need "+ "to generate it manually and place it "+ - "to ~/.out-of-tree/images/. "+ - "Check documentation for additional information.", + "to ~/.out-of-tree/images/; "+ + "check documentation for additional information", fileurl) return } diff --git a/cmd/db.go b/cmd/db.go index e4faab5..4e40a5e 100644 --- a/cmd/db.go +++ b/cmd/db.go @@ -371,7 +371,7 @@ func openDatabase(path string) (db *sql.DB, err error) { } if version != currentDatabaseVersion { - err = fmt.Errorf("Database is not supported (%d instead of %d)", + err = fmt.Errorf("database is not supported (%d instead of %d)", version, currentDatabaseVersion) return } diff --git a/cmd/debug.go b/cmd/debug.go index 9a49267..51b77f4 100644 --- a/cmd/debug.go +++ b/cmd/debug.go @@ -240,7 +240,7 @@ func firstSupported(kcfg config.KernelConfig, ka config.Artifact, } } - err = errors.New("No supported kernel found") + err = errors.New("no supported kernel found") return } diff --git a/cmd/images.go b/cmd/images.go index cfa0f1e..a5db623 100644 --- a/cmd/images.go +++ b/cmd/images.go @@ -55,7 +55,7 @@ func (cmd *ImageEditCmd) Run(g *Globals) (err error) { } if len(kcfg.Kernels) == 0 { - return errors.New("No kernels found") + return errors.New("no kernels found") } ki := distro.KernelInfo{} diff --git a/cmd/kernel.go b/cmd/kernel.go index 5d5e049..0ce1bb1 100644 --- a/cmd/kernel.go +++ b/cmd/kernel.go @@ -235,7 +235,7 @@ func (cmd *KernelListCmd) Run(g *Globals) (err error) { } if len(kcfg.Kernels) == 0 { - return errors.New("No kernels found") + return errors.New("no kernels found") } for _, k := range kcfg.Kernels { @@ -298,7 +298,7 @@ func (cmd *KernelAutogenCmd) Run(kernelCmd *KernelCmd, g *Globals) (err error) { for _, sk := range ka.Targets { if sk.Distro.Release == "" { - err = errors.New("Please set distro_release") + err = errors.New("please set distro_release") return } diff --git a/cmd/pew.go b/cmd/pew.go index 9e1558a..43a65c4 100644 --- a/cmd/pew.go +++ b/cmd/pew.go @@ -940,7 +940,7 @@ func (cmd PewCmd) performCI(ka config.Artifact) (err error) { swg.Wait() if !found { - err = errors.New("No supported kernels found") + err = errors.New("no supported kernels found") } return @@ -949,7 +949,7 @@ func (cmd PewCmd) performCI(ka config.Artifact) (err error) { func kernelMask(kernel string) (km config.Target, err error) { parts := strings.Split(kernel, ":") if len(parts) != 2 { - err = errors.New("Kernel is not 'distroType:regex'") + err = errors.New("kernel is not 'distroType:regex'") return }