From 4e3313b6db54ff6c6a43df41a1afdf082628320b Mon Sep 17 00:00:00 2001 From: Mikhail Klementev Date: Tue, 8 Oct 2024 12:01:53 +0000 Subject: [PATCH] feat: parameter to write per-run logs to directory --- cmd/pew.go | 66 ++++++++++++++++++++++++++++++++++-------------------- 1 file changed, 42 insertions(+), 24 deletions(-) diff --git a/cmd/pew.go b/cmd/pew.go index fae9c55..5acd205 100644 --- a/cmd/pew.go +++ b/cmd/pew.go @@ -12,6 +12,7 @@ import ( "math/rand" "os" "os/exec" + "path/filepath" "strings" "time" @@ -90,6 +91,8 @@ type PewCmd struct { OutputOnSuccess bool `help:"show output on success"` RealtimeOutput bool `help:"show realtime output"` + LogDir string `help:"write logs to directory"` + Endless bool `help:"endless tests"` EndlessTimeout time.Duration `help:"timeout between tests" default:"1m"` EndlessStress string `help:"endless stress script" type:"existingfile"` @@ -403,39 +406,54 @@ func (cmd PewCmd) testArtifact(swg *sizedwaitgroup.SizedWaitGroup, defer swg.Done() - logdir := "logs/" + cmd.Tag - err := os.MkdirAll(logdir, os.ModePerm) - if err != nil { - log.Error().Err(err).Msgf("mkdir %s", logdir) - return - } + var logDirWriter *zerolog.ConsoleWriter + if cmd.LogDir != "" { + logdir := filepath.Join(cmd.LogDir, cmd.Tag) + err := os.MkdirAll(logdir, os.ModePerm) + if err != nil { + log.Error().Err(err).Msgf("mkdir %s", logdir) + return + } - logfile := fmt.Sprintf("logs/%s/%s-%s-%s.log", - cmd.Tag, - ki.Distro.ID.String(), - ki.Distro.Release, - ki.KernelRelease, - ) - f, err := os.Create(logfile) - if err != nil { - log.Error().Err(err).Msgf("create %s", logfile) - return - } - defer f.Close() + logfile := fmt.Sprintf("logs/%s/%s-%s-%s.log", + cmd.Tag, + ki.Distro.ID.String(), + ki.Distro.Release, + ki.KernelRelease, + ) + f, err := os.Create(logfile) + if err != nil { + log.Error().Err(err).Msgf("create %s", logfile) + return + } + defer f.Close() - slog := zerolog.New(zerolog.MultiLevelWriter( - &ConsoleWriter, - &FileWriter, - &zerolog.ConsoleWriter{ + logDirWriter = &zerolog.ConsoleWriter{ Out: f, FieldsExclude: []string{ "distro_release", "distro_type", "kernel", + "command", + "workdir", }, NoColor: true, - }, - )) + } + } + + var slog zerolog.Logger + if logDirWriter != nil { + slog = zerolog.New(zerolog.MultiLevelWriter( + &ConsoleWriter, + &FileWriter, + logDirWriter, + )) + } else { + slog = zerolog.New(zerolog.MultiLevelWriter( + &ConsoleWriter, + &FileWriter, + )) + } switch LogLevel { case zerolog.TraceLevel, zerolog.DebugLevel: